MyOnlineStore / omnipay-klarna-checkout

Klarna Checkout gateway for Omnipay
MIT License
13 stars 12 forks source link

update classes and tests to be compatible with new omnipay packages #44

Closed digibeuk closed 6 years ago

digibeuk commented 6 years ago

in line with the version numbers used bij omnipay I would suggest we make this available as the 3.0 branch.

~The minimum requirement for the package is also from now on php 7.1.~

See also : https://github.com/thephpleague/omnipay-common/releases/tag/v3.0.0

This should be throroughly tested.

Feijs commented 6 years ago

in line with the version numbers used bij omnipay I would suggest we make this available as the 3.0 branch

Should it be merged to master then? If that is that case, a 1.0 branch should be made from the current master, so we can create updates and fixes untill the 3.0 branch is releasable and the transition to php ^7.1 has been made.

Alternatively, I would suggest creating a 3.0 branch from master and directing this PR there

digibeuk commented 6 years ago

Should it be merged to master then? If that is that case, a 1.0 branch should be made from the current master, so we can create updates and fixes untill the 3.0 branch is releasable and the transition to php ^7.1 has been made.

Alternatively, I would suggest creating a 3.0 branch from master and directing this PR there :+1:

mattias-persson commented 6 years ago

Is this still considered a WIP or is it ready to be merged?

Feijs commented 6 years ago

Is this still considered a WIP or is it ready to be merged?

Looks like there are still a few unaddressed/unanswered questions, nor do I think it has been sufficiently tested in practice (at least not by me). So I would consider this WIP still.

The author is currently unavailable, but I'm sure he can provide an update upon his return. And I'll do some testing in the meantime.

digibeuk commented 6 years ago

Is this still considered a WIP or is it ready to be merged?

@mattias-persson it is still a WIP at the moment I am trying to find some time to get back at the task.