search

MycroftAI / documentation

Mycroft.AI documentation for all public facing technical components.
https://mycroft.ai/documentation
Apache License 2.0
80 stars 90 forks source link

add Andrea Electronics USB SUMA #178

Closed fermulator closed 4 years ago

fermulator commented 4 years ago

tested this and it is working! - add to https://mycroft-ai.gitbook.io/docs/using-mycroft-ai/get-mycroft/picroft#tested-hardware

krisgesling commented 4 years ago

Will handle the items in the linked issue separately, but for this device specifically, does removing the hard coded defaults get it working, or do you need to set the play commands to use this device?

I'm assuming the string in the notes column is the device name so wondered if that was needed to get it working.

fermulator commented 4 years ago

I don't think #2622 issue is specific to this device. ANY sound hardware that isn't "the first" device, will have its playback broken. But indeed, I had to remove the hard coded "first" entries to make this work, which all that does is allow the playback utils to use pulseaudio defaults (which is how it should be anyway). To be clear, I did not change the playback util params to be hard coded to this device.

The extra bits in the notes column was for reference. It is a way for users to more concisely recognize which device we are claiming support for. (IMO an improvement, but none of the other devices have this specification/clarity ... so I can understand maybe if the team decides it is "too verbose").

EDIT: @krisgesling sound good?

krisgesling commented 4 years ago

Makes sense, thanks again :)