search

MycroftAI / documentation

Mycroft.AI documentation for all public facing technical components.
https://mycroft.ai/documentation
Apache License 2.0
80 stars 90 forks source link

README.md imports #182

Closed JayKayy closed 4 years ago

JayKayy commented 4 years ago

Updating to show what the current msk import produces.

krisgesling commented 4 years ago

Hi Jay,

Thanks for the submission. I can see the benefit in consistency between what's generated by MSK and what's in the introduction documentation.

One benefit of the current import code is that it matches the rest of the code on this page. So if you cut and paste all the code snippets you would (almost) have a functioning Skill.

Perhaps we should go the other way and modify the output of MSK?

JayKayy commented 4 years ago

That works for me whatever makes the most sense to you. I was just getting started with a skill and was confused as to whether my code should look like that or not. I guess I should have just opened an issue highlighting the confusion this could cause new developers. I'm fine if you want to close/reject this and I'll open an issue for discussion.

krisgesling commented 4 years ago

Yeah that would be great, and thanks for taking the time to raise it!