search

MycroftAI / mycroft-dinkum

A consumer ready version of Mycroft specifically for the Mark II.
Apache License 2.0
20 stars 8 forks source link

WolframAlfa not running. #44

Open amunizp opened 2 years ago

amunizp commented 2 years ago

Describe the bug A clear and concise description of what the bug is.

Wolfram Alfa skill does not seem to work as described on MARK2.

To Reproduce Steps to reproduce the behavior:

  1. "hey mycroft"
  2. "What's 18 times 4?" returns an "I don't understand" and "How tall is Mount Everest?" returns the wikipedia article response.

Expected behavior A clear and concise description of what you expected to happen.

  1. expected wolfram alfa logo showing on screen after searching response.
  2. I expect the response to be the direct answer to the multiplication or question.

Log files If possible, add log files from /var/log/mycroft/ to help explain your problem.

You may also include screenshots, however screenshots of log files are often difficult to read and parse.

If you are running Mycroft, the Support Skill helps to automate gathering this information. Simply say "Create a support ticket" and the Skill will put together a support package and email it to you.

Environment (please complete the following information):

Additional context Add any other context about the problem here.

https://github.com/MycroftAI/mycroft-dinkum/tree/master/skills

Looking into https://market.mycroft.ai/skills I see the following: Screenshot from 2022-11-28 22-40-14

Please think carefully about whether you have modified anything in Mycroft's code or configuration files. If so, can you reproduce this on a clean installation of Mycroft? Many "bugs" turn out to be non-standard configuration errors.

amunizp commented 2 years ago

Confirmed it needs intent: https://github.com/MycroftAI/mycroft-dinkum/blob/master/skills/query-wolfram-alpha.mark2/vocab/en-us/WolframAlpha.voc

krisgesling commented 2 years ago

Hey there, thanks for raising this ticket.

There are two ways to get results from Wolfram - if you explicitly ask for wolfram it should only use that service which is what that .voc file does. The other way is to just ask a question, and then Wolfram is one of the services that gets queried.

I just tried this on a Mark II and found that a correct response is returned for:

"what is 18 * 4"

however fails on:

"what's 18 * 4"

These should both get normalized to the expanded form "what is" for processing so I presume something is going wrong at that point, which results in the bug you've identified.

amunizp commented 1 year ago

Just to be clear, then is the bug the that it is not understanding "what's" or that it needs to be clearer in the documentation?

krisgesling commented 1 year ago

That it is not understanding "What's". There is no reason someone should have to explicitly say "what is" vs "what's", and also no reason why Skill developers should need to specially account for both in their intent definitions.