fix pacman call - Githubissues

MycroftAI / mycroft-gui

The Graphical User Interface used by the Mycroft Mark II and more

Apache License 2.0

167 stars 57 forks source link

fix pacman call #80

Open emphasize opened 3 years ago

emphasize commented 3 years ago

Problem

Non-English system configurations will run into problems with former approach "yes | pacman ..."

Simply added a --noconfirm and --needed (to not reinstall packages present) instead of the existing statement. The -y added should be baseline since it renews the listings and prevents failures due to old lists.

Type of PR

[x] Bugfix
[ ] Feature implementation
[ ] Refactor of code (without functional changes)
[ ] Documentation improvements
[ ] Test improvements

CLA

👍

ChanceNCounter commented 3 years ago

Wellp, I just tried it. It works... but I failed to intercept it in time to prevent a kernel and driver upgrade from piggybacking.

I don't think the --noconfirm is wise on Arch or Manjaro (nor, perhaps, was yes)

emphasize commented 3 years ago

With problems i meant breakage as they would need a translated 'yes'.

Anyhow, how do you get a kernel update with this?

ChanceNCounter commented 3 years ago

It seems to have behaved like a -Syu, but I can't see why.