search

MycroftAI / mycroft-skills-kit

Mycroft Skills Kit
Apache License 2.0
28 stars 12 forks source link

Feature Request: Support SSH based remote url #20

Open krisgesling opened 5 years ago

krisgesling commented 5 years ago

For developers using SSH keys with github, the remote url is in the form: git@github.com:krisgesling/deckchair-cinema-skill instead of the https standard: https://github.com/krisgesling/deckchair-cinema-skill.git

The MSK successfully submits and creates the PR, however the test runner fails as it "does not appear to be a git repository". See example test: https://jenkins.mycroft.team/job/19.02-skill-tester/133/console Currently, developers must change the remote url to the https format before submission.

Would it be worth testing for this format, and if found modifying this to the https standard during submission? Rather than handling multiple formats in MSM for example.

andlo commented 4 years ago

I think this will not be a issue when shifting to use GitHub Personal Access Tokens in MSK as theese only works with https and not ssh.

krisgesling commented 3 years ago

Just hit this again with this Skill submission: https://github.com/MycroftAI/mycroft-skills/pull/1473