Add icon and color getting when creating a skill

[LinusSkucas]

This will allow skill developers, when developing with msk, to be able to add an image, and set its color when using msk create

• When you submit the image, it is verified with font awesome, to make sure that it is a real image (and that you did just mistype it). 🔣
• When you submit the color, it checks that it is a "real" hex code by checking that there is a # in the front. 🌈
• I also added colored output, to make reading the directions easier, for such things as links, or errors, for the changes here. I'm going to do more work with color in the future (adding/unifying the color), but that's for another pr.
  • Finally, I removed the name field in settings meta.yaml since it's deprecated: mycroftai/mycroft-skills#1092

[krisgesling]

Hey Linus this looks excellent, thank you!

Love the color highlights too.

I was wondering if we can also add a test for the length of the color string? My understanding is that a hex code can only be 4 or 7 characters long (eg #CCC or #BADA55). So maybe something like:

validator=lambda x: "#" in x[0] and len(x) in [4, 7],
on_fail="\n{red}Check that you entered a valid Hex color code including the #, and try again.{reset}\n"

[forslund]

My 0.05 cent: Don't use a lambda if you can avoid it. Use an inner function if something like that's needed.

[LinusSkucas]

Alright, I can add that check but, I don't know how to make inner functions/how to use them in this particular case...

[forslund]

An inner function is basically declaring a function in the local scope...

def my_func():
    def my_inner(thing):
        return "hello " + thing

    print(my_inner("world"))

In the validator lambda example it would be replaced with a named function

    def validate(x):
        """Validator for color strings."""
        return x[0] == "#" and len(x) in [4, 7]

in the same scope as you declare the other things. Might be overzealous and definitely not a required change...but maybe later we'd like to add a more rigid check that the color code can be parsed as a hex value or something.

[LinusSkucas]

Alright, I added the length checking. I wasn't able to figure out the inner function, so I just used lambda.

[forslund]

Looks good, merging

[forslund]

Realized why an inner function wouldn't work here...this is not run in a function/method, it's in a class scope... Sorry for the wild goose chase.