MycroftAI / mycroft-timer

Mycroft AI official Timer Skill - set multiple named timers
https://mycroft.ai/skills
Apache License 2.0
7 stars 30 forks source link

[WIP] implement QML timer #83

Closed AIIX closed 3 years ago

AIIX commented 4 years ago

Description

timer-qml

Type of PR

If your PR fits more than one category, there is a high chance you should submit more than one PR. Please consider this carefully before opening the PR. Either delete those that do not apply, or add an x between the square brackets like so: - [x]

Testing

Interact with timer skill normally with GUI running

Documentation

TBD

CLA

AIIX commented 3 years ago

Hey thanks for this I've been using it a bit lately but finally got back to review in more detail.

There's one undefined variable given a specific path, and we may need to tweak the layout a little when two timers are displayed so that the name and countdown scale down, see example here

I couldn't replicate the scaling issue on my wave share 5inch display in horizontal mode using the latest qt image from debos, but I have anyways attempted a fix and changed some calculations for the layouts and pushed a new commit, let me know if it worked since I cant replicate it

krisgesling commented 3 years ago

Given how small the suggested changes are I just added them, hope that's alright.

There are a few other visual oddities I've noticed on specific pathways but I'll make issues for them and we can get this merged.

Thanks again!