MycroftAI / skill-npr-news

Mycroft AI official News Skill, providing the latest news report from your favorite broadcast.
https://mycroft.ai/skills
Apache License 2.0
9 stars 42 forks source link

Fix stop vocab only working for common play usage #109

Closed krisgesling closed 3 years ago

krisgesling commented 3 years ago

Description

An alternative to PR #108 - this adds Skill specific "stop" vocab that is only registered when the Skill is performing it's own local playback ie not through the Common Play Framework.

As the intent is only active while the News Skill is playing, it is quite liberal with it's matching at the moment.

This also calls audioservice.stop() to allow the VK tests to pass. Remaining @xfail's are caused by the Timer Skill matching on Stop utterances when it has no alarms set or expired.

I don't believe this local vocab is a long term solution but we first need better contextual awareness and a unified playback system.

Type of PR

Testing

VK tests

krisgesling commented 3 years ago

Nope it does the current Mycroft standard behaviour of stopping everything. But if we're trying to stop the Alarm/Timer and not the news - shouldn't we use converse on those rather than this one?

ken-mycroft commented 3 years ago

Yea, that's why I figured we should hold off on this. I have a PR going in today which addresses the issue.