Bugfix - over matching preventing other media playback

MycroftAI / skill-npr-news

Mycroft AI official News Skill, providing the latest news report from your favorite broadcast.

https://mycroft.ai/skills

Apache License 2.0

9 stars 42 forks source link

Closed krisgesling closed 4 years ago

krisgesling commented 4 years ago

Add new tests to check that News Skill doesn't trigger when it's not meant to Awaiting merge of mycroft-core PR #2618
Add more matching levels to better represent confidence
Add strong confidence for short CPS phrases like "play the news"
Abstracted get_default_station for use in CPS - fixes #79
Add 0.6 confidence for CPS phrases that contain "news" and the short title of a feed
Add simple check for short title of feed in utterance of regular intent - fixes #75

forslund commented 4 years ago

Just tested it out, it works much better :+1:

krisgesling commented 4 years ago

Just switched the method for detecting audio service messages.

It's the same method as the Singing Skill, but abstracted since we do it for each of the play, pause and stop commands.

krisgesling commented 4 years ago

Ake confirmed working and tests passing. Merging.