search

MycroftAI / skill-npr-news

Mycroft AI official News Skill, providing the latest news report from your favorite broadcast.
https://mycroft.ai/skills
Apache License 2.0
9 stars 42 forks source link

Added newsfeed for the state of Hessen (Germany) #96

Open thorstenMueller opened 4 years ago

thorstenMueller commented 4 years ago

As requested in issue #48 i've added a german newsfeed (radiostation) for the state of Hessen.

krisgesling commented 4 years ago

Hey Thorsten,

With recent updates I've realised that we need to change the way we handle settings changes in the backend. Currently anytime a small change like this is made to a Skill, the backend treats it as a completely different block of settings. This means that it effectively wipes the settings for all existing users.

So I'm not keen to merge any more settings changes until we find a better way to handle this scenario. Unfortunately without the settings change, you would need to request the station by name each time.

A different way to get around this might be to update the default_stations function to provide more granular defaults? Eg anyone else in Hessen should get this by default rather than a more generic national station.

thorstenMueller commented 4 years ago

Hey Kris.

This means that it effectively wipes the settings for all existing users.

Oh, didn't know about that. Due i've currently no idea on how you could optimize your backend i wish you best of luck for finding a more suitable solution.

thorstenMueller commented 4 years ago

Hey @krisgesling . I've updated the PR based on your chat session.

What do you think?

krisgesling commented 4 years ago

Looks good.

"hr info" is a little hard to trigger as a station name but is the alias working well when you ask for the station by name?

thorstenMueller commented 4 years ago

Hey @krisgesling Sorry for the late response. I'll check this within the next days and give you feedback.