MycroftAI / skill-stop

Mycroft AI official Stop Skill - stop the actions of a Skill that are in progress
https://mycroft.ai/skills
Apache License 2.0
8 stars 26 forks source link

en: add more stop words #47

Closed Mic92 closed 2 years ago

Mic92 commented 2 years ago

Type of PR

Testing

works for me

Documentation

-

CLA

-

krisgesling commented 2 years ago

Hey Jörg,

Thanks for getting involved and submitting these.

The "stop" vocab is a little more challenging than it first seems and these variations might have some unintended consequences.

As an example:

"Hey Mycroft, play some music" Music is playing

"Hey Mycroft, uhh nothing" Music stops playing

So whilst they are similar a lot of the time, as humans we use a lot of contextual factors to decide whether things like "cancel" or "nothing" mean "stop" in a particular context. So a challenge for us is how we enable Mycroft to make those same judgements about the intent behind potentially ambiguous language, as well as what the intent was in reference to. Eg is the user wanting to cancel the wake word activation, or the music, or something else?

While we work that out I think our preference is to keep it simple and prioritize not doing the wrong thing ie if someone says "cancel" and the music keeps playing, they'll probably try other variations like "stop the music". So I don't think we want to include these variations just yet.

Mic92 commented 2 years ago

Ok. Is there some other standard intent to do a noop when Mycroft was accidentally triggered? Something that does not has any side-effects.

krisgesling commented 2 years ago

Try this one: https://github.com/ChanceNCounter/dismissal-skill