search

MycroftAI / skill-volume

Mycroft AI official Volume Skill - control the volume of your Device
https://mycroft.ai/skills
Apache License 2.0
10 stars 30 forks source link

try more potential mixer names #34

Closed benklop closed 5 years ago

benklop commented 5 years ago

I needed this to get volume controls to work with my JustBoom DAC pi hat.

forslund commented 5 years ago

Hi @benklop thanks for this contribution. From a glance it looks good and I'll test it out shortly.

To protect yourself, the project, and users of Mycroft technologies we require a Contributor Licensing Agreement (CLA) before accepting any code contribution. This agreement makes it crystal clear that along with your code you are offering a license to use it within the confines of this project. You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank you!

benklop commented 5 years ago

@forslund Just signed. thanks!

penrods commented 5 years ago

I just double-checked and you requested the CLA but did not digitally sign it using HelloSign. I resent the request for signature, it should be at the top of your email. It should be from HelloSign and say it is a signature request from Joshua Montgomery.

benklop commented 5 years ago

Thanks @penrods, I really did sign it this time!

forslund commented 5 years ago

Sorry for the delay on this, I didn't see the update in the contributors list. Merging now!