search

MycroftAI / skill-volume

Mycroft AI official Volume Skill - control the volume of your Device
https://mycroft.ai/skills
Apache License 2.0
10 stars 30 forks source link

Issues-41 - Reload mixer before volume change #42

Closed colla69 closed 5 years ago

colla69 commented 5 years ago

This change solves the problem i described here (https://github.com/MycroftAI/skill-volume/issues/41) It works for me, however i have no means of testing the functionality in an enclosure.

krisgesling commented 5 years ago

Hi colla69, thanks for the contribution!

I'm not having the same issue so can't verify but this doesn't seem to have any negative effect :)

Before merging your changes we require a Contributor Licensing Agreement (CLA). This agreement makes it crystal clear that along with your code you are offering a license to use it within the confines of this project. You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank you!

colla69 commented 5 years ago

Hey gez, i signed the CLA, as Andrea Colarieti Tosti (a.colarietitosti@googlemail.com). Thank you and have a nice day :)

krisgesling commented 5 years ago

Tracked it down, thanks!