Allow end user to specify a default volume as a percentage value

lnguyenh commented 4 years ago

Description

This PR allows the end-user to specify a preferred default volume in the settings on the Mycroft website (here: https://account.mycroft.ai/skills ). The volume is set as a percentage value and not a level value. There is now a new settings "section" under the existing "Ducking" one. Screenshot: https://photos.app.goo.gl/MD5T7rBSJ9mL5GqX7

Type of PR

[x] Feature implementation

Testing

Testing was done with:

blacklisting the original volume skill and installing the modified one. Mycroft starts as expected, volume is set to the desired default value, and volume commands are still working.

Documentation

There was no existing docstring to modify

krisgesling commented 4 years ago

Hey there, thanks for contributing to Mycroft!

I don't think we'll be able to merge this yet as it comes in the context of some broader changes. There are two main things:

Anytime we change settings definitions, it resets everyone's settings for that Skill. It's on our backlog but not a priority yet to fix this. In the meantime we don't want to change settings_meta unless we really need to.
Default volumes need to be set at a range of levels so we shouldn't have a default value in the Skill. Eg different enclosures (Mark 1 vs Mark II vs a vending machine vs a nursing home assistant) may want different default levels depending on their use case and their hardware. I can however see the benefit in having a simple user definable default like this.

krisgesling commented 4 years ago

Also connected https://github.com/MycroftAI/skill-volume/pull/67

MycroftAI / skill-volume