MycroftAI / skill-wiki

Query Wikipedia articles
https://mycroft.ai/skills
Apache License 2.0
18 stars 33 forks source link

add specific intent handling for ask wiki, etc and convert to a commo… #64

Closed ken-mycroft closed 3 years ago

ken-mycroft commented 3 years ago

…n query skill

Description

Adds specific intent for calling out the skill by name. For example, ask wiki or wiki, tell us about bla.

Also converts the skill to a common query skill.

I removed manual disambiguation and replaced it with auto disambiguation and I fixed the bug where when you ask wiki what is an automobile it responds with what is a cat. This was due to the auto suggest feature which has been entirely removed. If in the future if bugs like this can be corrected we could add it back as it was a good idea but just not working.

I removed the 'more' feature as these skills now return more by default but because of corrected barge-in you can now simply say 'stop', which the VK tests do to improve performance.

I refactored the code (specifically the new fix_input() routine) but it still leaves a lot to be desired. The president of the united states returns none but now it returns the original query when this happens which also improves its ability to answer a wider range of questions.

I also corrected and added VK tests and a readme file in the test directory describing these enhancements and added code to the steps file.

Type of PR

Testing

How can someone reviewing this PR test that it is working properly? Is there appropriate test coverage for this change?

VK tests

Documentation

Readme file added to test directory

krisgesling commented 3 years ago

I'm assuming this is only an older version of the PR that has been merged and can be closed?

krisgesling commented 3 years ago

Also did we address the comments and questions raised here?

krisgesling commented 3 years ago

Closing - newer version of this PR was already merged