search

MystenLabs / sui

Sui, a next-generation smart contract platform with high throughput, low latency, and an asset-oriented programming model powered by the Move programming language
https://sui.io
Apache License 2.0
6.29k stars 11.22k forks source link

Fix "attemps" and other common misspellings in our code base #4353

Closed Clay-Mysten closed 2 years ago

Clay-Mysten commented 2 years ago

What are the existing URLs containing the issue, if any? https://github.com/search?q=org%3AMystenLabs+attemps&type=code

How would you describe the issue? (What needs changing?) @Romainua reports:

It is the metrics of nodes, URL individual for each, but comments are the same for all. 
http://ip:9184/metrics
I think attemps must be attempts, a minor problem
# HELP gossip_total_attempts_cert_downloads Total number of certs/effects download attemps through gossip/node sync process
Thanks

@brad-mysten points to the query above for all such refs.

Where should this information land if new? (Learn, Build, Explore, Contribute.)

In the files above.

What changes are needed to support this new feature or product? (A simple overview, detailed procedures?)

Fix some typos.

Who is the audience for that information? (App developers, investors, creators, validators, someone else?)

All.

What precisely must they do with it? (Configure a new service? Process some output?)

Better understand our code.

Clay-Mysten commented 2 years ago

If we are to make these fixes, we should look for other common misspellings, which I’ve now done using likely words from: https://en.wikipedia.org/wiki/Commonly_misspelled_English_words https://www.infoplease.com/culture-entertainment/journalism-literature/frequently-misspelled-words https://www.cnbc.com/2021/05/07/most-commonly-misspelled-words-that-make-you-look-less-smart-according-to-grammar-experts.html

And finding the following issues in addition to: https://github.com/search?q=org%3AMystenLabs+attemps&type=code https://github.com/search?q=org%3AMystenLabs+enviroment&type=code https://github.com/search?q=org%3AMystenLabs+libary&type=code https://github.com/search?q=org%3AMystenLabs+maintainance&type=code https://github.com/search?q=org%3AMystenLabs+recieve&type=code https://github.com/search?q=org%3AMystenLabs+publically&type=code https://github.com/search?q=org%3AMystenLabs+devent&type=code

So I will start addressing them together and pinging the Explorer team before touching the improperly spelled function name SendRecieveView found from the related query above.

randall-Mysten commented 2 years ago

Corrected attemps, deferring others for future updates