Closed tania-pires closed 3 years ago
This looks great to me @tania-pires ! 🎉
Breaking this into frontend tasks I see:
set for implementation (wireframes show implementation)
- uses the
notes_public
endpoint
set for implementation (see description in original post for implementation)
- uses the
repository
endpoint
I don't think this one was designed into the wireframes but that's alright (I imagine that is partially because those links on the right side haven't been updated since previous work to reflect the current state of the website). The description in the original comment I think is descriptive enough for implementation so we can move forward with this one.
set for implementation (minor change from wireframes)
- uses the
other_resources
endpoint
I don't think we are given nice name labels like are in the wireframes but if we place the links there for now we can bring this up with ADMG.
modified implementation
- uses
nasa_missions
endpoint- only a few campaigns will have these. This section should disappear for other campaigns.
I really like what the design has here. It is very visually appealing. Unfortunately at this point I think all we get returned from the API is the name of the mission, not an image, description, or link to the home website. I think ADMG will like this idea but we will have to wait for them to provide content if we are going to move forward with this design. For now perhaps we can keep the section header the same and then maybe add the mission names as cards like the Focus Areas in this design are listed? ~If we have a generic satellite icon that has already been designed maybe that could go in place of the Focus Area logo. @tania-pires what do you think about this?~ Sounds like 98% of the NASA Missions are satellites but one (Radex supporting the Olympex campaign) was another campaign. We could still use logos but it is less appealing now that there would be some hard coding for now.
set for implementation
- uses
significant_events
endpoint
I think this one is ready to move forward. I have some broader thoughts about addressing the non-human readable names, distinguishing between deployments and campaigns, and modifying how we should the length of events on the timeline, but I think that those should be saved and we will open another ticket in the future to revisit more generally improvements to the timeline.
The final note I'll make is that this wireframe has the Work In Progress version of the science keywords. For the upcoming sprint we are not making those changes since 1) they are not the priority and 2) they are not fully designed, so don't worry about those changes. The changes to the Platforms & Instruments section are also a part of a separate ticket.
NASA Missions
Design implication: @tania-pires Can we do some kind of small card or something instead of the text and image you have right now?
Other Resources
For now we can move forward with just raw URLs in the links.
Design Changes
[x] Change header "NASA Missions" -> "Supported NASA Missions"
[x] Change Platforms and instruments color background to bluish
[x] Add deployment dates hover on the header
[x] Change text hierarchy on Platforms and Instruments dropdowns content
[x] More distinction between significant events and deployments in the timeline
[x] "Supported NASA Missions" - small card
In response to a question from @AliceR: @tania-pires suggests that "Other Resources" go below the "Program Info" section
@AliceR pointed out some redundancies in the information in the "Overview" section at the top and the "Program Info" section at the bottom. I started documenting these redundancies here.
In the end there is a redundancy of two links, which I don't think is bad I think we should just ask ADMG for a more consistent name for each. We may also at some point want to clarify what each of the top links refers to, but I will call that out of scope for that ticket. The repositories
endpoint is the only endpoint getting added in this ticket that overlaps with the others. The way that is described in the original post to integrate this endpoint I think will actually make it clearer what "Repositories" means and help with clarity.
I want to avoid blowing up the PR #200 even more. What is missing to close this issue is:
Observation to raise about NASA missions: currently, it is really only a comma separated string that the backend provides. Should we ask to add more mission data like logo, url, ...?
@AliceR To your comment about the NASA missions the question was raised and ADMG liked it. Gathering satellite links and images is just not at the top of their priority list so we should move forward for the medium-term future without them.
Information to Add
notes_public
significant_events
nasa_missions
repositories
other_resources
Details
Notes for each of the new pieces of information.
notes_public
Examples:
significant_events
We don't necessarily have to include all the information about the significant event in the timeline card right now.
reference_file
andpublished_list
I already excluded because they either don't make sense or return null.Examples:
nasa_missions
Examples:
repositories
Examples of long names (each one also has a link):
other_resources
Example (each campaign seems to have 2-6 links): https://lvis.gsfc.nasa.gov/Data/Maps/Gabon2016Map.html https://www.nasa.gov/centers/armstrong/multimedia/imagegallery/C-20A/AFRC2016-0054-539.html https://www.nasa.gov/sites/default/files/atoms/files/xpress_afrisar.pdf https://earth.esa.int/documents/10174/134665/AfriSAR-Final-Report https://airbornescience.nasa.gov/sites/default/files/documents/ASP_Spring2016_nsltr_rev.pdf
This issue is related to #146