NASA-IMPACT / veda-ui

Frontend for the Dashboard Evolution project
Other
25 stars 5 forks source link

Make Data selector modal work #1213

Closed hanbyul-here closed 1 month ago

hanbyul-here commented 1 month ago

Related Ticket: #1156

Description of Changes

Notes & Questions About Changes

I will inline-comment

Validation / Testing

netlify[bot] commented 1 month ago

Deploy Preview for veda-ui ready!

Name Link
Latest commit ce6bd1cbd9564bdc5747a2c3b6a53f8c10db2a72
Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/671a8ba571dd2400083de190
Deploy Preview https://deploy-preview-1213--veda-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dzole0311 commented 1 month ago

The main reason the data selector modal was not working is ~ again ~ link-related components error. I made it use linkProperties props.

🤯

sandrahoang686 commented 1 month ago

Hmm.. i'm still running into the same error i mentioned in the ticket when running your nextJs branch code data-selector-modal-test.. am i missing something? I'm not even able to validate because of this original error Screenshot 2024-10-28 at 11 23 09 AM

sandrahoang686 commented 1 month ago

Update: Needed to build the library - forgot that step :woman-facepalming: This only exposes the data selector modal though so once this merges along with the other state tickets, we need a ticket to connect everything. Something like get Layer Selection Modal & EA flow working. @hanbyul-here did you want to create that ticket or shall I?

hanbyul-here commented 1 month ago

Please create the ticket 🙇 @sandrahoang686