search

NASA-IMPACT / veda-ui

Frontend for the Dashboard Evolution project
Other
25 stars 5 forks source link

Remove minHeight prop #1265

Closed dzole0311 closed 1 week ago

dzole0311 commented 1 week ago

Related Ticket: https://github.com/NASA-IMPACT/veda-ui/issues/1264

Description of Changes

Removed minHeight prop to avoid undesired card behavior. The css prop was introduced here: https://github.com/NASA-IMPACT/veda-ui/pull/1244

Notes & Questions About Changes

{Add additonal notes and outstanding questions here related to changes in this pull request}

Validation / Testing

  1. Open the stories page where there are card components
  2. Verify that the images in the cards no longer have a minHeight property
  3. Verify that the card layout appears consistent and the image heights are reduced compared to the previous behavior on v10.0.0

Or see the Air Quality card here:

netlify[bot] commented 1 week ago

Deploy Preview for veda-ui ready!

Name Link
Latest commit 4f9c6799a0a99f9be28929e6098abaff831dc9ad
Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/673e12e39435940008700c40
Deploy Preview https://deploy-preview-1265--veda-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

slesaad commented 1 week ago

@dzole0311 isn't that prop needed for the default solid color fill in case an image isn't provided?

dzole0311 commented 1 week ago

@slesaad I had to clean up my local cache (was switching between the Next.js repo and this one) before I noticed the problem 🤦 I pushed one more change, and would appreciate another look!

Also, I’ve updated our mock data to exclude the image for one of the cards which makes it easier to spot if something looks odd in next releases.

dzole0311 commented 1 week ago

GHG Center preview: https://deploy-preview-667--ghg-demo.netlify.app/

slesaad commented 1 week ago

@aboydnw - @dzole0311 fixed that issue in the new commit, there's an example in this page https://deploy-preview-1265--veda-ui.netlify.app/stories

dzole0311 commented 1 week ago

Thanks all for verifying the fix!

@aboydnw, as @slesaad mentioned, you can review the "External Link Test" card on this page (not the GHG Center preview). It has no media and displays the default background color.