NASA-IMPACT / veda-ui

Frontend for the Dashboard Evolution project
Other
25 stars 5 forks source link

Adjusting rescale value for small/large numbers #1272

Open snmln opened 6 days ago

snmln commented 6 days ago

Related Ticket: https://github.com/orgs/NASA-IMPACT/projects/17?pane=issue&itemId=85258058&issue=NASA-IMPACT%7Cveda-ui%7C1226

Description of Changes

Notes & Questions About Changes

When observing a value in either the max or min inputs if that value has a character count of 6 or greater the component will convert that number into scientific notation as a display value.

Validation / Testing

Run this branch on the veda-config code base, navigate to the E&A page and select the difference CO2 dataset. This is an extreme data set that should display all changes in this component.

netlify[bot] commented 6 days ago

Deploy Preview for veda-ui ready!

Name Link
Latest commit 1d4d878020d084e274ba347ac4adc9c7b1d08d17
Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/67476ff4a81b4400088b8bcc
Deploy Preview https://deploy-preview-1272--veda-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aboydnw commented 6 days ago

@snmln I assume you're looking at NO2 diff, not CO2 diff. Just commenting here for posterity, I think this is an acceptable visualization of these small/large numbers.

image

Only question is, were you able to test this out where the magnitude of the min/max were both <0.01?

snmln commented 6 days ago

CO2 will also display a 1.5e-6 value I believe, so both NO2 and CO2 will work for testing purposes. And yes, I was able to confirm the 2 extremes of the data visualization will present as desired. Screenshot 2024-11-22 at 2 43 42 PM

vgeorge commented 23 hours ago

@snmln when visiting the dataset you recommended, I was able to see that the inputs are always on scientific notation and I was able to edit then. However, I noticed a couple of small things:

Screenshot 2024-11-28 at 10 00 02

rescale