search

NASA-NAVO / servicemon

1 stars 6 forks source link

Changed create_service_plots to not try to open a browser when asked … #63

Closed trjaffe closed 3 years ago

trjaffe commented 3 years ago

…to write HTML file.

trjaffe commented 3 years ago

Though I'm puzzled by why the CI worked despite this. Maybe its environment is smarter.

tomdonaldson commented 3 years ago

Though I'm puzzled by why the CI worked despite this. Maybe its environment is smarter.

The CI coverage is poor for the analysis code, so this wouldn't have been exercised at all.

codecov[bot] commented 3 years ago

Codecov Report

Merging #63 (c5699c7) into main (7083401) will decrease coverage by 0.04%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   51.69%   51.64%   -0.05%     
==========================================
  Files          15       15              
  Lines        1151     1152       +1     
==========================================
  Hits          595      595              
- Misses        556      557       +1
Impacted Files Coverage Δ
servicemon/analysis/basic_plotting.py 18.05% <0.00%> (-0.26%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7083401...c5699c7. Read the comment docs.