search

NASA-SW-VnV / ikos

Static analyzer for C/C++ based on the theory of Abstract Interpretation.
Other
2.03k stars 150 forks source link

[analyzer] Use pip to install package (#233). #234

Closed ivanperez-keera closed 11 months ago

ivanperez-keera commented 11 months ago

The current installation scripts for python programs don't place files exactly where/how expected, resulting in errors like:

$ ikos
error: could not find ikos python module
error: see TROUBLESHOOTING.md

even when PYTHONPATH is set correctly.

Instead of trying to fix the issue, it's worth it to switch to an alternative that is more up-to-date, where the problem does not happen.

The current installation scripts for python programs included in IKOS use easy_install, which has been deprecated (https://setuptools.pypa.io/en/latest/history.html#v58-3-0).

This commit replaces calls to the setup.py script, with calls to pip, which is one of the recommended solutions for python package installation.

ivanperez-keera commented 11 months ago

I'd be happy if someone other than me could double check that it's working on their end. I did test this in the CI.

ivanperez-keera commented 11 months ago

Also, if it does work for you, please don't merge this right away. There's a few simultaneous PRs, and I'd like to merge them in a specific way. Thanks! :)

ivanperez-keera commented 11 months ago

@arthaud I'm planning to merge today. I assume you are too busy, but just letting you know in case you want to try before I merge. Thanks!