Adding PhantomJs role for CSS Regression testing

NBCUTechnology / pubstack

⛔️ [DEPRECATED] Publisher's DevStack

MIT License

8 stars 8 forks source link

Adding PhantomJs role for CSS Regression testing #168

Closed sergesemashko closed 9 years ago

sergesemashko commented 9 years ago

Adding phantomJS rule for CSS regression testing.
Make sure package dependencies are installed for PhantomJS, see https://github.com/detro/ghostdriver/issues/170#issuecomment-60583895
Adding phantomJS 2 binary from https://github.com/eugene1g/phantomjs/releases, as it's not officially provided for ubuntu yet.
Adding vhost for nbcutelemundo prototype to make it accessible for making screenshot

Phantomjs 2.0.0 is required for proper fonts rendering, previous versions have a number of fonts rendering issues which are fixed in Phantomjs 2.0.0

@conortm @ericduran @scottrigby please review

scottrigby commented 9 years ago

@sergesemashko Do you also want to pull in patternlab, to be run from inside the VM? Or is that best to keep on the host machine (your mac, etc)?

scottrigby commented 9 years ago

I still don't have my head around how/if pubstack can help with Patternlab, Fepper, etc. Question posted for discussion :8ball:

sergesemashko commented 9 years ago

@scottrigby patternlab for telemundo comes with Publisher7_nbcutelemundo, it's already in the repo. So if you setting up machine for Telemundo, patterlab is already there. For other projects you might need to pull in patternlab, but I don't know any use case yet to write proper tasks for that. Patternlab might be a separate rule when we establish common way of working with it across projects.

ericduran commented 9 years ago

@scottrigby I think we treat pattern lab like a site. Since its a git checkout. So that's on their local machine.

sergesemashko commented 9 years ago

@ericduran ,unfortunately, Phantomjs 2.0.0 binary sources for linux are not deployed yet by maintainers. Compiling on local takes hours. I took compiled binary from here. But I'm not sure if they will be there after deployment to official site. So, how about to keep binary in pubstack repo until it is available on official site?

sergesemashko commented 9 years ago

@conortm , updated PR according to you comments

sergesemashko commented 9 years ago

@conortm I moved ruby out from apt-get install to dependencies to build ruby from source.

conortm commented 9 years ago

This looks good to me, @ericduran @scottrigby?

scottrigby commented 9 years ago

@conortm I can't build it locally right now, but if it runs OK (aside from the newline thing) it looks good to me!

conortm commented 9 years ago

This is a :+1: from me. @ericduran @scottnath, yay or nay?

scottrigby commented 9 years ago

:+1: from me

ericduran commented 9 years ago

That was my :+1: since everyone else is ok with it.

scottrigby commented 9 years ago

@ericduran yeah i was waiting for you to weigh in since you had opinions on this earlier in the thread. Glad this is in (for frontend implementation devs sake) :mindblown: