codecov-commenter
commented
2 weeks ago :warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 30.76923% with 18 lines in your changes missing coverage. Please review.
Project coverage is 39.00%. Comparing base (
e92c967) to head (3c7e86a).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| main.go | 0.00% | 17 Missing :warning: |
| download/download.go | 66.66% | 0 Missing and 1 partial :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #458 +/- ## ========================================== - Coverage 39.22% 39.00% -0.23% ========================================== Files 11 11 Lines 1968 1974 +6 ========================================== - Hits 772 770 -2 - Misses 1084 1092 +8 Partials 112 112 ``` | [Flag](https://app.codecov.io/gh/NBISweden/sda-cli/pull/458/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NBISweden) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NBISweden/sda-cli/pull/458/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NBISweden) | `39.00% <30.76%> (-0.23%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NBISweden#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
pahatz
jbygdell
Related issue(s) and PR(s)
This PR closes #442 .
Description The user should be able to provide the config file location argument ONLY before the subcommand of the cli.
How to test For test coverage, some of the existing tests have been altered to follow the new allowed order of providing the config, i.e. before the subcommand. To manually test, one should test individually the cli commands that are affected. Those are the ones that are using the config as an argument(upload, list htsget, download).