Not showing if affinity is by chassis ID

NBKRedSpy / BTShowMechAffinity

3 stars 0 forks source link

Not showing if affinity is by chassis ID #2

Open hongooi73 opened 1 year ago

hongooi73 commented 1 year ago

Hey, thanks for making this mod! Really cuts down on the odds of picking the wrong pilot for a mech. Sometimes it's not a big deal, but for things like a +1 init buff, it can make a big difference.

Just one thing I noticed: while the mod is fine for "normal" affinities (those selected via AssemblyVariant if you have CustomSalvage, or prefab+tonnage if not), it doesn't seem to work when the affinity is by chassis ID. In this case the affinity itself still works, but the pilot won't be highlighted or moved to the top of the list. See pic below; Glitch has affinity with the mech, but ShowMechAffinity doesn't pick it up.

This is with MechAffinity 1.4 which apparently changed things quite a bit from 1.3.

Thanks again!

NBKRedSpy commented 1 year ago

Thanks for the heads up. If you can give me the save file and the list of all the mods that you are running, I'll see if I can get that handled.

NBKRedSpy commented 1 year ago

To be a bit more clear, I'll need to be able to mirror your BattleTech install to test with the save.

hongooi73 commented 1 year ago

Hi, sorry for the late response. This is with the Expanded Arsenal modpack, which includes quite a few mods. I'm actually in the middle of a major update for EA, which is how I came across the issue: I updated MechAffinity and also added a couple of affinities that go by chassis ID. Unfortunately that means you can't quite replicate the issue with mods off of the Nexus.

If it helps, I've attached the offending affinity file and save. I'll reply again when I've uploaded the EA update to the Nexus, which hopefully won't be long now.

affinity.zip

hongooi73 commented 1 year ago

I've uploaded my EA update to Nexus, which includes the latest MechAffinity: https://www.nexusmods.com/battletech/mods/635

However, I realised you shouldn't need to download the whole thing to repro this bug. You can do this as follows:

Update MechAffinity, per the instructions at the repo
Copy the affinity json file in the zip file above into mods/MechAffinity/AffinityDefs
Edit the IDs in the chassisNames entry to include a mech that you have
Take that mech out for a spin
You should see that your pilot now has 1 mission listed for that chassis, but they won't be highlighted by ths mod