NCAR / CUPiD

CUPiD is a “one stop shop” that enables and integrates timeseries file generation, data standardization, diagnostics, and metrics from all CESM components.
https://ncar.github.io/CUPiD/
Apache License 2.0
25 stars 24 forks source link

Updated PR for seaice notebook. #138

Closed dabail10 closed 1 week ago

dabail10 commented 2 months ago

All Submissions:

New Feature Submissions:

  1. [X] Does your submission pass tests?
  2. [x] Have you lint your code locally prior to submission?

Changes to Core Features:

I have made several updates to the sea ice notebook here.

  1. Modified the cice_vars.yml file to have only three variables. I have created a new cice_vars_full.yml file for other use cases.
  2. Changed the color tables from tab20 to ocean.
  3. Added some Antarctic plots.
  4. Added (in comments) a PBS DASK cluster option for running the notebook within jupyterhub.
  5. Modified the cases in config.yml to be historical runs for seaice.
  6. As an aside, I have also moved the timeseries files to ice/proc/tseries/month_1 for all of the cases instead of "ts".
dabail10 commented 2 months ago

I apologize for all of the commit / push nonsense. I was trying to figure out the pre-commit stuff. I finally fixed it all!

dabail10 commented 2 months ago

I guess I still need some help here with the PR Tasks.

mnlevy1981 commented 2 months ago

Might be a little late now, but you can have pre-commit run these checks locally -- instructions are in the Contributor's Guide

dabail10 commented 2 months ago

Might be a little late now, but you can have pre-commit run these checks locally -- instructions are in the Contributor's Guide

I tried to install and run pre-commit, but I couldn't figure it out. Is it just pip install pre-commit? I did this and it still did not find the command.

mnlevy1981 commented 2 months ago

I guess I still need some help here with the PR Tasks.

That's meant to be a "pass if all the checklist items are complete, fail if something still needs to be done" but it isn't working quite right -- @TeaganKing is talking to the NCAR organization admin team to see about installing a better tool for that check. We can merge this in even if that check is failing, the pre-commit test is the important one

mnlevy1981 commented 2 months ago

Might be a little late now, but you can have pre-commit run these checks locally -- instructions are in the Contributor's Guide

I tried to install and run pre-commit, but I couldn't figure it out. Is it just pip install pre-commit? I did this and it still did not find the command.

It should already be installed in (cupid-dev), so try activating that environment and then running the pre-commit commands

dabail10 commented 2 months ago

Might be a little late now, but you can have pre-commit run these checks locally -- instructions are in the Contributor's Guide

I tried to install and run pre-commit, but I couldn't figure it out. Is it just pip install pre-commit? I did this and it still did not find the command.

It should already be installed in (cupid-dev), so try activating that environment and then running the pre-commit commands

Ok. So, I had not updated the cupid-dev environment in many months. We should probably have something in the workflow about this if we don't already.

TeaganKing commented 2 months ago

I guess I still need some help here with the PR Tasks.

That's meant to be a "pass if all the checklist items are complete, fail if something still needs to be done" but it isn't working quite right -- @TeaganKing is talking to the NCAR organization admin team to see about installing a better tool for that check. We can merge this in even if that check is failing, the pre-commit test is the important one

See #139 -- this should be implemented shortly.

dabail10 commented 1 week ago

I am waiting on this until the latest CUPiD is up to date.