search

NCAR / geocat-applications

GeoCAT Applications is a community resource inspired by the NCL Applications page.
https://ncar.github.io/geocat-applications/
Apache License 2.0
5 stars 5 forks source link

Codespell should ignore image data #72

Closed andy-theia closed 4 months ago

andy-theia commented 5 months ago

Suggesting we configure codespell to ignore image data

kafitzgerald commented 5 months ago

Example here: https://results.pre-commit.ci/run/github/677032883/1719933484.CFPsQ4GEQ5COnsapb8xMrw

cyschneck commented 5 months ago

Is the image data from a URL, generated, or stored locally?

kafitzgerald commented 5 months ago

Is the image data from a URL, generated, or stored locally?

It's an output image that's generated by code in the notebook.

We probably haven't run into this elsewhere because we generally clear the notebooks before committing them to the repo.

This was part of what prompted that Zulip thread earlier today.

anissa111 commented 5 months ago

Wait, we're not clearing the notebooks before committing them to the repo yet, though.

kafitzgerald commented 5 months ago

Yeah, I meant elsewhere on GeoCAT projects. That was unclear though.

cyschneck commented 4 months ago

Might be useful to enable codespell to be optional warning, but not prevent committing

-   repo: https://github.com/pre-commit/mirrors-mypy
    rev: v0.720
    hooks:
    -   id: mypy
        verbose: true
        entry: bash -c 'mypy "$@" || true' --