search

NCAR / noahmp

Noah-MP Community Repository
Other
71 stars 81 forks source link

Bug in computation of outputs SNOWENERGY and SOILENERGY for glacierized grid cells #140

Open emilycollier opened 2 months ago

emilycollier commented 2 months ago

In WRF v4.6.0, the heat capacity variable HCPCT is not initialized in module_sf_noahmpdrv.F, nor is it passed to/return from the call to noahmp_glacier in module_sf_noahmp_glacier.F. As a result, the computations for the output variables SNOWENERGY and SOILENERGY at L1380-1394 are not correct for glacierized grid cells, and simulations are not reproducible.

If you would like a PR, can you please let me know for which branch exactly? Thanks.

tslin2 commented 2 months ago

You may refer https://github.com/NCAR/hrldas/blob/master/tutorial/Note4_Code_Development_GitHub_Pull_Request.ipynb to the develop or NCAR:release-v4.6-WRF branch. Thanks.

jesusff commented 2 months ago

Thank you, Emily. Does this bug affect the default opt_gla = 1 configuration for glacier treatment?

emilycollier commented 2 months ago

As it relates to an incorrect initialization and update of HCPCT in the driving module, I think it is independent of any of the optional treatments, however it only impacts the diagnostics SNOWENERGY and SOILENERGY in glacierized grid cells.