search

NCAR / noahmp

Noah-MP Community Repository
Other
71 stars 81 forks source link

Snow compaction #148

Open RAbolafiaRosenzweig opened 1 month ago

RAbolafiaRosenzweig commented 1 month ago

Enables new snow compaction physics option using the enhanced scheme developed by Abolafia-Rosenzweig et al. (2024). This new physics option can be used by defining SNOW_COMPACTION_OPTION=2 in the namelist file.

Abolafia-Rosenzweig, R., He, C., Chen, F., Barlage, M., 2024. Evaluating and Enhancing Snow Compaction Process in the Noah-MP Land Surface Model. J Adv Model Earth Syst 16, e2023MS003869. https://doi.org.10.1029/2023MS003869

cenlinhe commented 1 month ago

Hi Ronnie, a few minor suggestions:

  1. please remove "!RAR" from the code.
  2. Include your paper as reference in your new compaction module here: https://github.com/NCAR/noahmp/pull/148/files#diff-0b59d5fc1c3d226094efe4310ffa808aad49ab623ecacd8c6014fe5a5a3f1ff6R16-R20
  3. line up the code for formatting. Some code lines are not lined up with the existing code.
  4. You currently have three "snow_compaction" commits. Could you please just use 1 commit to include all of your code updates here? For example, two of your current commits just include formatting changes, which are not worth separate commits.

Thanks!

RAbolafiaRosenzweig commented 1 month ago

These 4 suggestions have been accepted & incorporated.

tslin2 commented 1 week ago

Should this enhancement of SnowCompactBurdenFac to be considered an option in the Noah-MP parameter table or a new physics option in the namelist? One physics, but two options for the SnowCompactBurdenFac parameter (original and enhanced) in the Noah-MP parameter table? Thanks.