search

NCAR / noahmp

Noah-MP Community Repository
Other
71 stars 81 forks source link

green vegetation fraction scaling of max canopy capacity of rain & snow intercept #93

Closed tslin2 closed 1 year ago

tslin2 commented 1 year ago

This is a pull request method 1 of #91

cenlinhe commented 1 year ago

Let's wait until we have a discussion with Guo-Yue and Liang to see what the best strategy to fix the FVEG scaling issue would be.

barlage commented 1 year ago

Agreed. Note that I don't think this is the best solution to the issue. Also note that the scaling needs to occur here as well:

https://github.com/NCAR/noahmp/blob/ba9f679846d0f4e7595f219ee77474fdf70b53cb/src/CanopyHydrologyMod.F90#L70

tslin2 commented 1 year ago

yes, agree on both!

jesusff commented 1 year ago

This affects the non-refactored code as well, right? https://github.com/NCAR/noahmp/blob/release-v4.5-WRF/src/module_sf_noahmplsm.F#L1450

barlage commented 1 year ago

@jesusff yes, there will eventually need to be a second PR to the 4.5 branch