search

NCAR / noahmp

Noah-MP Community Repository
Other
71 stars 81 forks source link

Crop option=1 issue for planting, harvesting, etc. #99

Open cenlinhe opened 1 year ago

cenlinhe commented 1 year ago

In the current Noah-MP, when crop option = 1, the parameters like planting date, harvesting date, and GDD are first assigned with the values from the NoahmpTABLE.TBL parameters: https://github.com/NCAR/noahmp/blob/master/drivers/hrldas/BiochemVarInTransferMod.F90#L80 However, these parameters are then replaced by the variables from the crop static input file: https://github.com/NCAR/noahmp/blob/master/drivers/hrldas/BiochemVarInTransferMod.F90#L125 So this makes the calibrated NoahmpTABLE.TBL table values for those parameters not used. Everytime, users want to calibrate these parameters, they have to change the input file values. Is this something designed by purpose initially or is this a bug? I also checked the version before v5.0, they have the same treatment.

tslin2 commented 1 year ago

This seems to be an issue with single point and 2D regional simulations because these variables are not consistent for each grid cell. Perhaps the ideal model should read from a table for single point simulations but read from 2D input files (mainly from WPS) for regional simulations.

tslin2 commented 1 year ago

This is related to

76