Get missing values and dtype without re-opening the dataset

davidhassell commented 9 months ago

Description

Closes #179

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist

[x] This pull request has a descriptive title and labels
[x] This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
[x] Unit tests have been added (if codecov test fails)
[x] Any changed dependencies have been added or removed correctly (if need be)
[x] All tests pass

codecov[bot] commented 9 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b31ca82) 86.93% compared to head (53f4ed4) 87.11%.

Files	Patch %	Lines
activestorage/active.py	95.00%	2 Missing :warning:
activestorage/netcdf_to_zarr.py	80.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #180 +/- ## ========================================== + Coverage 86.93% 87.11% +0.17% ========================================== Files 8 8 Lines 620 613 -7 ========================================== - Hits 539 534 -5 + Misses 81 79 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

davidhassell commented 9 months ago

OK - tests passing :)

valeriupredoi commented 9 months ago

valiant effort @davidhassell ! Let me write us a couple tests for the missing statements, then will merge :+1: :beers:

NCAS-CMS / PyActiveStorage