NCAS-CMS / PyActiveStorage

Python implementation of Active Storage
2 stars 2 forks source link

Pin `kerchunk >=0.2.4` and fix change of API in new Kerchunk: compressor is now a filter #192

Closed valeriupredoi closed 8 months ago

valeriupredoi commented 8 months ago

Description

Checklist

kerchunk=0.2.2 is very old; kerchunk=0.2.3 had issues with numcodecs dependencies;kerchunk=0.2.4is nice and happy and has an optimization we worked on, but it moved thecompressor and compressor level inside thefiltersdictionary - this PR fixes that; also, this PR pins Kerchunk to>=0.2.4` so we don't have to run into old issues, and be able to use the optimization (selection on Dataset or Group to do kerchunking on)

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 87.78%. Comparing base (9e2bfd3) to head (20a246c).

Files Patch % Lines
activestorage/netcdf_to_zarr.py 75.00% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #192 +/- ## ========================================== - Coverage 88.40% 87.78% -0.62% ========================================== Files 8 8 Lines 664 696 +32 ========================================== + Hits 587 611 +24 - Misses 77 85 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.