Closed davidhassell closed 7 months ago
@davidhassell look at my test fixes here https://github.com/valeriupredoi/PyActiveStorage/pull/197/commits/8b46b4b034c2db577d46f50d5d3f0e6a9cb7b080 pls bud, and let me know if this is OK with you, then I'll approve and merge - cheers muchly! :beer:
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.54%. Comparing base (
b43dd21
) to head (8b46b4b
). Report is 1 commits behind head on pyfive.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@davidhassell look at my test fixes here 8b46b4b pls bud, and let me know if this is OK with you, then I'll approve and merge - cheers muchly! 🍺
frenly ping @davidhassell :chicken: TBF I completely forgot about it myself :laughing:
Hi V - finally got round it it :) https://github.com/valeriupredoi/PyActiveStorage/commit/8b46b4b034c2db577d46f50d5d3f0e6a9cb7b080 looks fine to me, thanks.
yay! Cheers @davidhassell :beer:
Fixes #194
Raised against branch
pyfive
for @bnlawrenceThis small change should have made it into #196 !
Before you get started
Checklist