NCAS-CMS / PyActiveStorage

Python implementation of Active Storage
2 stars 2 forks source link

Set count to 0 for 0-sized data #197

Closed davidhassell closed 7 months ago

davidhassell commented 8 months ago

Fixes #194

Raised against branch pyfive for @bnlawrence

This small change should have made it into #196 !

Before you get started

Checklist

valeriupredoi commented 8 months ago

@davidhassell look at my test fixes here https://github.com/valeriupredoi/PyActiveStorage/pull/197/commits/8b46b4b034c2db577d46f50d5d3f0e6a9cb7b080 pls bud, and let me know if this is OK with you, then I'll approve and merge - cheers muchly! :beer:

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.54%. Comparing base (b43dd21) to head (8b46b4b). Report is 1 commits behind head on pyfive.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## pyfive #197 +/- ## ======================================= Coverage 90.54% 90.54% ======================================= Files 7 7 Lines 550 550 ======================================= Hits 498 498 Misses 52 52 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

valeriupredoi commented 7 months ago

@davidhassell look at my test fixes here 8b46b4b pls bud, and let me know if this is OK with you, then I'll approve and merge - cheers muchly! 🍺

frenly ping @davidhassell :chicken: TBF I completely forgot about it myself :laughing:

davidhassell commented 7 months ago

Hi V - finally got round it it :) https://github.com/valeriupredoi/PyActiveStorage/commit/8b46b4b034c2db577d46f50d5d3f0e6a9cb7b080 looks fine to me, thanks.

valeriupredoi commented 7 months ago

yay! Cheers @davidhassell :beer: