search

NCAS-CMS / cfa-conventions

NetCDF Climate and Forecast Aggregation (CFA) Conventions
https://github.com/NCAS-CMS/cfa-conventions/blob/main/source/cfa.md
1 stars 1 forks source link

Allow scalar `address` variables #46

Closed davidhassell closed 1 year ago

davidhassell commented 1 year ago

Fixes #45

nmassey001 commented 1 year ago

Yeah, this is fine by me and the way I restructured the code last week means that any variable can be scalar.

davidhassell commented 1 year ago

Thanks all. I'll merge after I've put in Sadie's suggestion.

@sadielbartholomew. I think it would be good to got the way of CF and have one sentence per line. Were you involved in implementing that? Would you like to do so again ... :)

sadielbartholomew commented 1 year ago

I think it would be good to got the way of CF and have one sentence per line. Were you involved in implementing that? Would you like to do so again ... :)

Good idea! I was I believe, and certainly I am happy to volunteer if you want that done and don't particularly want to do it yourself...

davidhassell commented 1 year ago

Thanks, @sadielbartholomew. All yours ...

sadielbartholomew commented 1 year ago

Thanks David, I can put a quick PR in, but I am just thinking that maybe I should wait until some of your open PRs are merged, since there are currently three open, all with my review approval but awaiting others'. Shall I wait, and is there any way we can speed up getting those merged?