search

NCATComp410 / comp410_summer_2023

Repository for COMP-410 summer 2023
GNU General Public License v3.0
0 stars 3 forks source link

Added detection for social security #20

Closed natalyapolite1 closed 1 year ago

claesmk commented 1 year ago

I'm also not clear on how test_political_group_detection() got removed, it will need to be added back

natalyapolite1 commented 1 year ago

I'm also not clear on how test_political_group_detection() got removed, it will need to be added back

When trying to commit, I am receiving errors. I am not sure what the issue is now.

natalyapolite1 commented 1 year ago

@claesmk I have updated the positive test cases. I am unable to move forward in completing the assignment until the change review has been approved.

claesmk commented 1 year ago

Somehow you managed to delete test_name_detection and also revert the "results" type-o from test_phone_number_detection. I'm not clear how this happened. Last night I merged main into your branch for you. Your initial commit changed a couple of ssn test cases, however, your final commit caused the aforementioned issue.

I'll fix this for you and commit