NCATSTranslator / Feedback

A repo for tracking gaps in Translator data and finding ways to fill them.
7 stars 0 forks source link

Update KG2 for KL/AT (Fugu), Unsecret Update latest KG2 (Guppy) #850

Closed sstemann closed 2 days ago

sstemann commented 1 month ago

Could be minor but is there another option instead of "UNKNOWN"?

image

https://ui.test.transltr.io/main/results?l=Metaphyseal%20Chondrodysplasia,%20Jansen%20Type&i=MONDO:0007982&t=0&r=0&q=0351d580-45b7-4c7b-8cb1-c56a798f7d66

@mbrush tagging you for this DISEASES source KL/AT tagging. I think it's ARAX > KG2 > Diseases

image

dnsmith124 commented 1 month ago

In the case of this edge the UI's FE receives a knowledge level of "unknown" for this source, tagging @gprice1129 for input on how to proceed.

sierra-moxon commented 1 month ago

I believe @saramsey and Erica are working on a new release of RTX-KG2 with KL/AT filled in that should be released in Fugu (Sprint 4). The default here for KPs should be "not provided" if the KL or AT can not be determined. Maybe the UI could use "Not Provided" by default instead of "UNKNOWN"?

gprice1129 commented 1 month ago

@mbrush this is KL mixed, please advise.

saramsey commented 1 month ago

See these issues to track our team's progress toward providing KL/AT in the RTX-KG2 KP: https://github.com/RTXteam/RTX-KG2/issues/358 https://github.com/RTXteam/RTX/issues/2319

My understanding from @ecwood is that the code updates for providing KL/AT edge attributes in the KG2pre graph build are already completed. Now the downstream work (@amykglen and @sundareswarpullela can comment) to provide those edge attributes in KG2c and in responses returned by the RTX-KG2 KP, is happening. We are aiming to roll this out in Sprint 4 (7/26 release-to-test deadline).

saramsey commented 1 month ago

This is fixed in CI, and the fix should be in the updated RTX-KG2 that is slated to be deployed to ITRB TEST early next week. See #818 for more details about that deployment.

sstemann commented 3 weeks ago

this is still in the UI in Fugu, my guess is that Unsecret needs to ingest the latest KG2 with these changes, but I can't see the support graphs in the ARAX GUI anymore.

Unsecret Only Results image

Disease Edges image

In this specific query, ARAX does not have results.

https://ui.test.transltr.io/main/results?l=Metaphyseal%20Chondrodysplasia,%20Jansen%20Type&i=MONDO:0007982&t=0&r=0&q=6cc2f6d5-75b4-4f1d-8eac-34d9f61c6477

image

It looks fixed for ARAX https://ui.test.transltr.io/main/results?l=Aceruloplasminemia&i=MONDO:0011426&t=0&r=0&q=0e83e4a4-0af7-4b6d-8287-53fecd44b8f2

image

image

kaiwenho commented 3 weeks ago

this is still in the UI in Fugu, my guess is that Unsecret needs to ingest the latest KG2 with these changes

Yes. Unsecret will have this solved by the end of the current sprint (Guppy) via importing KGs that contain information of KL and AT.

kaiwenho commented 2 weeks ago

this is still in the UI in Fugu, my guess is that Unsecret needs to ingest the latest KG2 with these changes Yes. Unsecret will have this solved by the end of the current sprint (Guppy) via importing KGs that contain information of KL and AT.

Unsecret has updated the KGs in CI. The AT and KL for each edges (inferred or component) can be seen now.

sierra-moxon commented 2 days ago

closing as complete!