search

NCEAS / metadig-checks

MetaDIG suites and checks for data and metadata improvement and guidance.
Apache License 2.0
8 stars 9 forks source link

reconsider how to handle service checks #406

Open jeanetteclark opened 3 years ago

jeanetteclark commented 3 years ago

There are two checks related to services in the FAIR suite - resource.serviceType.present and resource.serviceLocation.present.

These look in 

/*/identificationInfo/SV_ServiceIdentification/containsOperations/SV_OperationMetadata/connectPoint/CI_OnlineResource/linkage/URL
/*/identificationInfo/SV_ServiceIdentification/pointOfContact/CI_ResponsibleParty/individualName/*/text()[normalize-space()]
/*/identificationInfo/SV_ServiceIdentification/pointOfContact/CI_ResponsibleParty/organisationName/*/text()[normalize-space()]
/*/identificationInfo/SV_ServiceIdentification/pointOfContact/CI_ResponsibleParty/positionNam/*/text()[normalize-space()]
/*/identificationInfo/SV_ServiceIdentification/serviceType/LocalName

These xpaths seem correct if the resource is a service, however all dataset resources get dinged on this check. We might consider only looking here if the resource is listed as a service using the scopeType field.

We also might consider how/whether we might implement service checks on distribution URLs for entities. I'm not sure to what degree this would be supported in EML, and it doesn't seem to have support for ISO in the way that ISO is most commonly used.