NCEAS / metadig-webapp

Web service for interacting with the MDQ Engine API
1 stars 2 forks source link

Move metadig-webapp code to metadig-engine repo #16

Closed gothub closed 2 years ago

gothub commented 2 years ago

This repo produces a metadig-webapp war file and a Tomcat based Docker container (metadig-controller) that makes this war available.

This container provides the REST API frontend to metadig-engine. A new version of metadig-webapp and the associated container can be released independently of metadig-engine if the API changes and metadig-engine doesn't.

Are there any other reasons to keep this repo separate from metadig-engine repo?

In the interest of simplifying metadig-engine releases and reducing overhead, I'd like to incorporate the metadig-webapp code into the metadig-engine repo and retire the metadig-webapp repo.

Comments?

mbjones commented 2 years ago

In an idealized world, we would use different images for each of the containers, where each image only contained the code needed for that particular container task. Would that be more or less conveniently done in one repo versus multiple. Isn't the evolving best practice is one Dockerfile per repo?

gothub commented 2 years ago

Lots of interesting discussion regarding monorepos vs multirepos, if that is what you are referring to:

I'll close this for now, as the proposed merging of repos doesn't really buy us much at the moment.