NCIOCPL / cgov-digital-platform

The Cancer.gov Digital Communications Platform
GNU General Public License v2.0
11 stars 33 forks source link

(#4360) NCIDS List styles "for" Mini Landing Pages #4418

Closed dev-rana-publicis closed 2 months ago

dev-rana-publicis commented 3 months ago

Closes #4360 ODE: https://ncigovcdode806.prod.acquia-sites.com/

cgdp-management-server[bot] commented 3 months ago

ODE Deployment

Code has been deployed to ODE 806.

sarinapadilla commented 3 months ago

@dev-rana-publicis, @welshja and I discussed the componentVariant parameter for analytics and made a change. It'll now be passing either "Title and Description" or "Title, Description, and Image" for the two new templates. I've updated the ticket accordingly!

KateMashkinaNIH commented 3 months ago
  1. Files in the list are broken - it adds a file path before title
  2. Media links do not have media types next to the title Infographic Override/Page Title (Infographic) Video title: Video Override/Page Title (Video)
Screenshot 2024-08-19 at 11 02 35 AM
  1. In the Title, Descr and Image list - when a list item without a promo image is added, it's title is not aligned with the rest list items Screenshot 2024-08-19 at 10 38 31 AM
bryanpizzillo commented 3 months ago

A collection has 16.160px of margin above the <ul>. It has 12px of padding above the first list item. So when there is a heading, this 28.160px of spacing makes sense between the heading and the first list item. When there is no list item, this is additional space added between the sections. So it looks weird when there is no heading.

sarinapadilla commented 3 months ago

Per UX meeting on 8/22, we're increasing the margin-bottom on the images to .75rem.

blilianyu commented 3 months ago

There is an extra space being added before the file name in parentheses. Is this just jaml being weird or a bug?

Screenshot 2024-08-23 at 10 19 41 AM
dev-rana-publicis commented 2 months ago

The initial requirements for this PR asked to filter the cgov_list item styles based on what the MLP Page Style is. If the MLP Page Style is Standard, then cgov_list item styles will only display the legacy styles. If the MLP Page Style is NCIDS, the cgov_list item styles will only display the NCIDS styles. We were unable to get this to work in a quick and efficient way so instead, we will be handling this through governance. The cgov_list component will show all list item styles on the dropdown and we will need to ensure that the content editor selects the correct choice based on what the MLP Page Style is. @bennettcc @sarinapadilla @andyvanavery31

blilianyu commented 2 months ago

@dev-rana-publicis Can we have the file type/size (Infographic) (Video) be the same token size as the Collection title h3/MD/20px?

Screenshot 2024-09-05 at 3 16 35 PM
bennettcc commented 2 months ago

Feedback from @KateMashkinaNIH :

We are still having an issue with file types displaying.

On this test page, I only see PDF as icon, json and csv file type: https://ncigovcdode806.prod.acquia-sites.com/api-test/a/kate

This is the OG list ( scroll to the end where I added some files ):

https://ncigovcdode806.prod.acquia-sites.com/test/mini-landing/li-title-desc-img

Legacy lists will show a whole lot more of the icons( not only PDF) and the rest will be just a file extension ( here are the requirements that I found in the platform WIKI https://github.com/NCIOCPL/cgov-digital-platform/wiki/Paragraph-Type-Links#files )

bennettcc commented 2 months ago

Fed team (Anna, Alex, Jorge) have approved List as of 9/9