Closed dev-rana-publicis closed 2 months ago
Code has been deployed to ODE 806.
@dev-rana-publicis, @welshja and I discussed the componentVariant
parameter for analytics and made a change. It'll now be passing either "Title and Description" or "Title, Description, and Image" for the two new templates. I've updated the ticket accordingly!
A collection has 16.160px of margin above the <ul>
. It has 12px of padding above the first list item. So when there is a heading, this 28.160px of spacing makes sense between the heading and the first list item. When there is no list item, this is additional space added between the sections. So it looks weird when there is no heading.
Per UX meeting on 8/22, we're increasing the margin-bottom
on the images to .75rem.
There is an extra space being added before the file name in parentheses. Is this just jaml being weird or a bug?
The initial requirements for this PR asked to filter the cgov_list item styles based on what the MLP Page Style is. If the MLP Page Style is Standard
, then cgov_list item styles will only display the legacy styles. If the MLP Page Style is NCIDS
, the cgov_list item styles will only display the NCIDS styles. We were unable to get this to work in a quick and efficient way so instead, we will be handling this through governance. The cgov_list component will show all list item styles on the dropdown and we will need to ensure that the content editor selects the correct choice based on what the MLP Page Style is.
@bennettcc @sarinapadilla @andyvanavery31
@dev-rana-publicis Can we have the file type/size (Infographic) (Video) be the same token size as the Collection title h3/MD/20px?
Feedback from @KateMashkinaNIH :
We are still having an issue with file types displaying.
On this test page, I only see PDF as icon, json and csv file type: https://ncigovcdode806.prod.acquia-sites.com/api-test/a/kate
This is the OG list ( scroll to the end where I added some files ):
https://ncigovcdode806.prod.acquia-sites.com/test/mini-landing/li-title-desc-img
Legacy lists will show a whole lot more of the icons( not only PDF) and the rest will be just a file extension ( here are the requirements that I found in the platform WIKI https://github.com/NCIOCPL/cgov-digital-platform/wiki/Paragraph-Type-Links#files )
Fed team (Anna, Alex, Jorge) have approved List as of 9/9
Closes #4360 ODE: https://ncigovcdode806.prod.acquia-sites.com/