(#4379) NCIDS Summary Box - MLP

NCIOCPL / cgov-digital-platform

The Cancer.gov Digital Communications Platform

GNU General Public License v2.0

11 stars 33 forks source link

(#4379) NCIDS Summary Box - MLP #4441

Closed dev-rana-publicis closed 2 months ago

dev-rana-publicis commented 2 months ago

Closes #4450 Closes #4379 ODE: https://ncigovcdode820.prod.acquia-sites.com/

welshja commented 2 months ago

For analytics, on https://ncigovcdode820.prod.acquia-sites.com/test/ncids-mini-landing-summary-box on the summary box with no title, I'm getting "ERROR" as the title value. Per requirements it should be set to "Not Defined". Everything else looking good to me for analytics so far.

andyvanavery31 commented 2 months ago

@dev-rana-publicis from Slack, please update the font sizes to be the ones in the Specifications section of the ticket: The summary box heading will be stylistically an h3 (token size MD / 20px / Line-height 2)

dev-rana-publicis commented 2 months ago

9/12 Push Fixes:

Changes the usa-summary-box__heading styles to be styled as a H3
Fixes analytics to return Not Defined when there is no heading present
Changed example page scenario to include italicized heading

andyvanavery31 commented 2 months ago

@dev-rana-publicis can you please update the following:

The width of the Summary Box to match the width of measure per the comps linked in the ticket
The WYSIWYG for the body paragraph so that headings are not included in that field?
Add the <aside> to the component for accessibility purposes

dev-rana-publicis commented 2 months ago

9/18 Push Fixes:

We created a new format called NCIDS Streamlined No Headings and set that as our CKEditor format for the summary box body content. We should expect content editors to NOT see heading formats when editing the summary box content.
The summary box width should now be set to 88ex
Confirm summary box heading font-size, font, and line-height
Made the summary box an <aside>
Added usa-prose to summary box content. Please confirm that styles look correct.
Addressed #4450

welshja commented 2 months ago

Analytics looking good to me on the latest build!

cgdp-management-server[bot] commented 2 months ago

ODE Deployment

Code has been deployed to ODE 830.

andyvanavery31 commented 2 months ago

@dev-rana-publicis can you please update the heading in the Summary Box to be an <h2> instead of a <div>?

andyvanavery31 commented 2 months ago

Summary Box has been approved by the client.