zkamvar
commented
7 years ago Hi @smanel,
Please comment on either in the discussion on #194 or directly on the submitted file: https://github.com/NESCent/popgenInfo/pull/194/files#diff-2ac4a3d4aff34d52918d88ec827aa060
The line numbers you are using for these comments refer to an older version of the vignette.
L7: I think that it would be nice to have a short explanation on the power Spectrum. I am aware that it is explained later. But if possible to introduce it shortly here, it would be wonderful. L51. I would prefer that the initial ref for MEM are given one time in the vignette and not only Wagner et al. 2016 L109:Not necessary to define again the power Spectrum. Already defined just above. L11:Unclear: z-scores of which tests? Add outliers after detection L234: population and deme are teh same? If yes better to keep population.