NESTCollaboration / nestpy

Raw Python bindings to the NEST library using pybind11.
GNU General Public License v3.0
13 stars 19 forks source link

Added a few more bindings (Wq_eV, GetDensity), and updated tutorial #78

Closed grischbieter closed 2 years ago

grischbieter commented 2 years ago

@vvelan @sophiafarrell I've done the changes to the tutorial that we discussed via email. I believe I've gone through and made the comments/labels to match the default LUX example.

I had a few issues with the tutorial -- perhaps with my python version (?) , I'm using 3.8.5 -- but I needed to change the detector syntax. Specifically, I changed: detector = nestpy.LUX_RUN3 to be detector = nestpy.LUX_Run03() and all of the calls such as detector.get_g1(detector()) to detector.get_g1(). I haven't seen/used the original syntax before, but I figure it was there for a reason, but it was throwing errors for me.

Lastly, I added some bindings: GetDensity(...) and WorkFunction(...). I added their usage to the tutorial as well.

I didn't address the S1,S2 Calculation mode switch statements yet. I figure that should be done on the C++ side first.

grischbieter commented 2 years ago

Great, thanks Sophia for double checking this. I'll merge this branch and close this pull request.

vvelan commented 2 years ago

Awesome, thanks both!

On Thu, Jan 27, 2022 at 12:42 PM Greg R.C. Rischbieter < @.***> wrote:

Great, thanks Sophia for double checking this. I'll merge this branch and close this pull request.

— Reply to this email directly, view it on GitHub https://github.com/NESTCollaboration/nestpy/pull/78#issuecomment-1023621310, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECSQ634H2FNLSCMQ5EYTODUYGUZTANCNFSM5M62K3QQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- Regards, Vetri Velan