search

NETWAYS / check_bareos

Icinga Plugin to check Bareos Backup Director databases
https://www.netways.de/
GNU General Public License v3.0
8 stars 7 forks source link

[Bug]: minor: Alarm level should be including #38

Closed mowgli closed 1 month ago

mowgli commented 2 months ago

Please try to fill out as much of the information below as you can. Thank you!

Which version contains the bug?

2.1.0

Describe the bug

The warning level for nagios checks is normally assumed to be inclusive. If the warning is set to 2 all equal and greater then 2 should create a warning. But at least with the command below, the warning is only issued when it is greater (not equal).

How to recreate the bug?

/usr/local/lib/nagios/plugins/check_bareos -U bareos --password-file /etc/bareos/db-password status --failedBackups --warning 2 --critical 5
martialblog commented 2 months ago

Hi,

The plugin supports the Threshold format: https://nagios-plugins.org/doc/guidelines.html#THRESHOLDFORMAT

If I read the docs correctly, it should work as expected? @RincewindsHat Second opinion please

10  < 0 or > 10, (outside the range of {0 .. 10})

check_stuff -w10 -c20   Critical if "stuff" is over 20, else warn
 if over 10 (will be critical if "stuff" is less than 0)
RincewindsHat commented 1 month ago

@martialblog this is correct.

martialblog commented 1 month ago

We gonna update the README to make things clearer.

martialblog commented 1 month ago

Updated the README. Gonna close this for now