search

NEUBIAS / bise

BIII development repository
http://biii.eu
GNU General Public License v2.0
5 stars 14 forks source link

BIII json export problem #175

Closed hmenager closed 3 years ago

hmenager commented 4 years ago

I have a problem with biii.eu: the json list of softs happens to be badly formatted lately, providing for each tool an HTML link instead of the software name (http://biii.eu/soft?_format=json). Now an entry looks like that:

{"title":"\u003Ca href=\u0022\/node\/1642\u0022 hreflang=\u0022en\u0022\u003End-safir\u003C\/a\u003E","nid":"1642"}

@albangaignard also mentions that the test server has the same issue.

PerrineGilloteaux commented 4 years ago

is fixed by https://github.com/NEUBIAS/bise/commit/72e2823ad00d3ca7d81d49fba2b32d7a57a32d0b , pull request to come, checking for any other rest export issues

miura commented 4 years ago

Looks OK.
Perrine, please avoid closing the issue until it becomes online, at least in the test site.

image

miura commented 4 years ago

I will pull from the test.biii.eu soon.

miura commented 4 years ago

It's now in test.biii.eu. @hmenager Please test by replacing the pointer to test.biii.eu temporally.

hmenager commented 4 years ago

Looks good to me on the test server. Thank you @PerrineGilloteaux @miura !

PerrineGilloteaux commented 4 years ago

Looks OK. Perrine, please avoid closing the issue until it becomes online, at least in the test site.

Hello Kota, many thanks for this , I think did not close it, but when you refer an issue in a commit with words such as "fix", accepting a pull request containing this commit will close the relative issue , I will then try to avoid the list of keywords mentionned here that makes this process automatic https://docs.github.com/en/enterprise/2.16/user/github/managing-your-work-on-github/closing-issues-using-keywords

joakimlindblad commented 3 years ago

Works. Fix deployed. Closing