NEZNAMY / TAB

"That" TAB plugin.
Apache License 2.0
932 stars 252 forks source link

Spectator Fix not working #1434

Open tooobiiii opened 3 weeks ago

tooobiiii commented 3 weeks ago

Server version

Velocity-CTD 3.4.0

TAB version

5.0.7

Plugin list

Image

Image

Describe the bug

Players see spectators when switching Important: If player joined and someone is already gm3 it works!!!

Expected behavior

Spectators should be hidden from Players without the permission

Steps to reproduce

Install TAB on velocity Enable Spectator Fix Have Someone without the perm join a backend Get yourself in gm3 Important: If player joined and someone is already gm3 it works!!!

Additional info

No response

Checklist

NEZNAMY commented 3 weeks ago

Image Are you sure tablist uuids match properly? You can identify this by setting different tabprefix and tagprefix and confirming it's indeed tabprefix appearing in tablist.

tooobiiii commented 3 weeks ago

i ticked this bc i trolled...

tooobiiii commented 3 weeks ago

i will check one sec

tooobiiii commented 3 weeks ago

seems like you are correct.

Image Changing this made no changes in tab

NEZNAMY commented 3 weeks ago

Try toggling use-online-uuid-in-tablist.

tooobiiii commented 3 weeks ago

still nothing changed

NEZNAMY commented 3 weeks ago

Is your proxy in online mode?

tooobiiii commented 3 weeks ago

sure is

NEZNAMY commented 3 weeks ago

Is your paper.yml configured to enable velocity support and forwarding and all of those weird complicated settings?

tooobiiii commented 3 weeks ago

should be ill double check

tooobiiii commented 3 weeks ago

Image

tooobiiii commented 3 weeks ago

i mean it always worked but eventually it broke Do you thing velocity ctd could be the issue?

NEZNAMY commented 3 weeks ago

Find out by switching to normal velocity.

tooobiiii commented 3 weeks ago

theres lots of players online atm i can check when theres fewer

tooobiiii commented 3 weeks ago

ill just setup a test network one sec

NEZNAMY commented 3 weeks ago

Try reproducing the issue on a test network on localhost.

tooobiiii commented 3 weeks ago

i started setting it up any ptero any specific reason for local?

NEZNAMY commented 3 weeks ago

No, that was just an idea. People usually say they don't have any test servers available when I tell them to try it there.

tooobiiii commented 3 weeks ago

just asking, any issue with enfore-secure-profile set to false? or in velocity anything related to chat reporting?

NEZNAMY commented 3 weeks ago

That shouldn't be related.

tooobiiii commented 3 weeks ago

well now luckperms placeholders wont resolve :D

NEZNAMY commented 3 weeks ago

That has nothing to do with this issue and isn't required to reproduce it.

tooobiiii commented 3 weeks ago

okay then im done

tooobiiii commented 3 weeks ago

Image Tab is still showing the placeholder on velocity now

NEZNAMY commented 3 weeks ago

After all this time I managed to configure velocity so that I can actually connect to it, I have use-online-uuid-in-tablist: true and it works Image

tooobiiii commented 3 weeks ago

no wait, it takes the tagprefix to tablist instead of tabpreifx

NEZNAMY commented 3 weeks ago

Yes? Isn't that what you described already?

tooobiiii commented 3 weeks ago

i changed tab instead of tag to indentify a change

tooobiiii commented 3 weeks ago

...

tooobiiii commented 3 weeks ago

so yea changing the prefix in groups.yml does indeed change the tablist prefix on the main server

tooobiiii commented 3 weeks ago

i thought tabprefix was the one to change in order to see that but i was wrong

NEZNAMY commented 3 weeks ago

I use:

proxies:
  bungee-cord:
    online-mode: true
  proxy-protocol: false
  velocity:
    enabled: true
    online-mode: true
    secret: <secret>

in paper-global.yml and

online-mode = true
force-key-authentication = true
player-info-forwarding-mode = "modern"

in velocity.toml.

Do you have the same settings?

tooobiiii commented 3 weeks ago

i can confirm yes

NEZNAMY commented 3 weeks ago

And the TAB setting on the same value? And regardless of whether it's true or false tabprefix still doesn't appear? Is the feature enabled?

tooobiiii commented 3 weeks ago

Well the tabprefix is not the problem. Tab prefix does appear and work properly the only thing i have issues with is the hide specators to users thing

NEZNAMY commented 3 weeks ago

Yes, and the most likely cause is tablist uuids not matching between expected and actual, and tablist formatting is an easy way to find out. Can you show output of /btab debug <player>?

tooobiiii commented 3 weeks ago

Image

NEZNAMY commented 3 weeks ago

Image you trolling?

tooobiiii commented 3 weeks ago

sorry if i missunderstood anything but the spectator fix setting is indeed enabled

NEZNAMY commented 3 weeks ago

I meant tablist formatting. Obviously we cannot confirm if tablist formatting works if the feature is disabled. Enable it back and see if it actually works. If it does, check if spectator fix is still broken on that test server (don't forget you'll still see yourself as spectator).

tooobiiii commented 3 weeks ago

now gives me this in debug need one sec booting my other client

Image i have 6.0.1 bridge installed

NEZNAMY commented 3 weeks ago

Not being connected is a very good reason why spectator fix may not be working.

tooobiiii commented 3 weeks ago

well soime fucked up configuration of mine oin the test server the main network is connected via bridge

tooobiiii commented 3 weeks ago

ill just enable it there and see

tooobiiii commented 3 weeks ago

Image i can see myself in tab as a spec (on other client)

NEZNAMY commented 3 weeks ago

what does /btab parse <spectator player> %gamemode% return?

tooobiiii commented 3 weeks ago

Image

tooobiiii commented 3 weeks ago

Were you able to reproduce the issue or is some configuration on my side fucked up

tooobiiii commented 3 weeks ago

And when a player is already in gm3 and another joins it works but it always fails when switching while both are online

NEZNAMY commented 3 weeks ago

Were you able to reproduce the issue

yes