search

NFT-Limited / nf-bugs

0 stars 0 forks source link

[FEATURE REQUEST] Collection image from the metadata #124

Open Marec4 opened 1 year ago

Marec4 commented 1 year ago

Is your feature request related to a problem? Please describe. Issuers specify the collection image in the metadata.

Describe the solution you'd like If there is a collection image specified in the metadata, we should use this.

For example: "collection": { "name": "xMals: Skulls", "family": "xMals", "description": "A collection of 5000 unique xMals Skulls having fun on the XRP Ledger.", "image": "ipfs://bafybeie3gh7b5mi6is4nvuqzh2sia5zvhn3hcrrqewqjlzrq27yokzdokq/0.png" },

Marec4 commented 11 months ago

Tested with xMals Skulls. Removed the collection image but it's not using the one specified in the metadata.

viktorhugo commented 11 months ago

I understand that the image of the metadata is the same one you are referring to, that is, if you delete the image from the collection it is the same image of the metadata to which it refers, that is why it was modified that when there is no image in the collection The first available image of your nfts is chosen

Marec4 commented 11 months ago

It's not the same image. Currently, the collection image is the one I added manually and uploaded to Filebase. If I remove the address from the field, it uses a random image from the collection, not the one specified in the metadata.

Image

Image

This is the image specified in the metadata: https://ejhod5lw7pkcfr72q6sdr5jwe7b7o364spgms4aaa3mpadkhgihq.arweave.net/Ik7h9Xb71CLH-oekOPU2J8P3b9yTzMlwAAbY8A1HMg8/0.png

viktorhugo commented 11 months ago

I understand what you mean, when a collection is saved the image value in the metadata (if it has one) is saved in the ImageUrl field in the collection, the URI field refers to the metadata, if it does not have the value of the field it does not the value of this could be obtained.

Marec4 commented 11 months ago

Unfortunately, it's still wrong. If we don't add the image manually, it has to use the one specified in the metadata. If not specified, then the first working image is like it is now.

With xMals, it should use this one from metadata:

"collection": { "name": "xMals: Skulls", "family": "xMals", "description": "A collection of 5000 unique xMals Skulls having fun on the XRP Ledger.", "image": "ipfs://bafybeie3gh7b5mi6is4nvuqzh2sia5zvhn3hcrrqewqjlzrq27yokzdokq/0.png"