NG-ZORRO / ng-zorro-antd-mobile

A configurable Mobile UI components based on Ant Design Mobile and Angular. 🐜
http://ng.mobile.ant.design
Other
800 stars 241 forks source link

fix(module: grid): fix columnNum and carouselMaxRow not work #705

Closed nuonuoge closed 4 years ago

nuonuoge commented 4 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

codecov[bot] commented 4 years ago

Codecov Report

Merging #705 into 1.x will increase coverage by 0.02%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.x     #705      +/-   ##
==========================================
+ Coverage   88.59%   88.62%   +0.02%     
==========================================
  Files         270      270              
  Lines        7622     7630       +8     
  Branches     1097     1099       +2     
==========================================
+ Hits         6753     6762       +9     
+ Misses        422      421       -1     
  Partials      447      447              
Impacted Files Coverage Δ
components/grid/grid.component.ts 88.63% <80.00%> (-0.12%) :arrow_down:
components/carousel/carousel.component.ts 70.80% <0.00%> (+0.67%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb9fd9c...5806655. Read the comment docs.