NG-ZORRO / ng-zorro-antd-mobile

A configurable Mobile UI components based on Ant Design Mobile and Angular. 🐜
http://ng.mobile.ant.design
Other
800 stars 241 forks source link

fix(module:Carousel) : fix when resize active slider error show #763

Closed tianchao1995 closed 4 years ago

tianchao1995 commented 4 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Eve-Sama commented 4 years ago
  1. Every PR need a issue to explain why we need it, and ref it in PR.
  2. You can use Chinese to write PR describe but PR title should be written in English.
codecov[bot] commented 4 years ago

Codecov Report

Merging #763 (f59bc38) into master (60d6b54) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #763   +/-   ##
=======================================
  Coverage   87.00%   87.00%           
=======================================
  Files         164      164           
  Lines        6641     6641           
  Branches     1107     1107           
=======================================
  Hits         5778     5778           
  Misses        421      421           
  Partials      442      442           
Impacted Files Coverage Δ
components/carousel/carousel.component.ts 69.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60d6b54...f59bc38. Read the comment docs.

Eve-Sama commented 4 years ago

BTW, the commit also should be English. Can you try to modify? Thanks.

tianchao1995 commented 4 years ago

765